Skip to content

chore: introduce expect.toContainClass (instead of partial: true) #35551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

chore: introduce expect.toContainClass (instead of partial: true) #35551

merged 5 commits into from
Apr 9, 2025

Conversation

@mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Apr 9, 2025

No description provided.

@mxschmitt mxschmitt requested a review from Copilot April 9, 2025 08:42
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

@github-actions

This comment has been minimized.

Sign in to view
dgozman
dgozman reviewed Apr 9, 2025
View reviewed changes
@mxschmitt @dgozman
Apply suggestions from code review
ce461f2 
Co-authored-by: Dmitry Gozman <[email protected]>
Signed-off-by: Max Schmitt <[email protected]>
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
dgozman
dgozman approved these changes Apr 9, 2025
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
mxschmitt and others added 2 commits April 9, 2025 13:00
@mxschmitt @dgozman
Update docs/src/api/class-locatorassertions.md
892203a 
Co-authored-by: Dmitry Gozman <[email protected]>
Signed-off-by: Max Schmitt <[email protected]>
@mxschmitt
nits
3997250
@mxschmitt mxschmitt requested a review from dgozman April 9, 2025 11:41
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

39111 passed, 807 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 22e134e into microsoft:main Apr 9, 2025
28 of 29 checks passed
@mxschmitt mxschmitt deleted the toContainClass branch April 9, 2025 12:47
This was referenced Apr 9, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mxschmitt @dgozman